Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.1.0 - Quality of Life Improvements #55

Merged
merged 62 commits into from
Apr 29, 2024
Merged

Release v4.1.0 - Quality of Life Improvements #55

merged 62 commits into from
Apr 29, 2024

Conversation

houseofcat
Copy link
Owner

@houseofcat houseofcat commented Apr 29, 2024

Project

  • Cleanup involving Constants.cs classes everywhere.
    • Logging message templates are now located next to the methods they were occurring.
  • Removing some locking, not because it wasn't necessary, it can be handled by developer's side rather than over complicating library code.
  • IReceivedMessage no longer creates a TaskCompletionSource that was only used by IPipelines.

Quality of Life

  • ConsumerDataflow / ConsumerDataflowService received a lot of simplifications to streamline their usage.
    • Provide direct access to the Dataflow/Options class to re-use values in RabbitOptions or create steps manually.
    • Various extension methods/constructors were improved to autowire up more things based on the ConsumerOptions values.
    • Autowiring up ISerializationProvider and ICompressionProvider/IEncryptionProvider as long as they were configured.
    • Added Send Encrypt/Compress to SendMessage support.
    • Streamline SendMessage usage and naming conventions to make it clearer what this entails.
  • OpenTelemetry span naming conventions are cleaner.

Various bug fixes included and started observing Code Coverage to improve code coverage for non-RabbitMQ code.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 2d1a2e91 26.88%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2d1a2e9) Report Missing Report Missing Report Missing
Head commit (1b69235) 7108 1322 18.60%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#55) 1090 293 26.88%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@houseofcat houseofcat merged commit 7fe3567 into publish Apr 29, 2024
5 of 6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant