feat: Set sensor occupancy upon alarm #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upon receiving alarm from the device (either via device notifications, or simulated from history) invoke the sensor activity callback to set the sensor occupancy - it helps when device notifications on triggerring sensor's activity aren't receveid by a reason. The occupancy is set only if sensor is known (i.e. alert references the sensor could be found in the list of those retrieved from the device in a cached manner), but only if the state isn't already set (e.g. by another callback). Please note the change might result in multiple callback invocations for same event - the handlers should be idempotent
|
1 similar comment
|
hostcc
added a commit
to hostcc/hass-gs-alarm
that referenced
this pull request
Aug 27, 2024
* `pyg90alarm` has been updated to most recent version, to set occupancy of the sensor triggered the alarm. Please see hostcc/pyg90alarm#36 for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note the change might result in multiple callback invocations for same event - the handlers should be idempotent