fix some new sonar issues

Why? After commit 58cbfe7, testing code is also checked by sonar.

runtime/src/main/java/hosh/runtime/CompilerCommand.java

@@ -1,3 +1,26 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2018-2023 Davide Angelocola
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
 package hosh.runtime;
 
 import hosh.spi.Command;

spi/src/test/java/hosh/spi/RecordsTest.java

@@ -166,5 +166,4 @@ void prependAndAppend() {
 		assertThat(a.prepend(Keys.TEXT, text)).isEqualTo(a.append(Keys.TEXT, text));
 		assertThat(a.append(Keys.TEXT, text)).isEqualTo(a.prepend(Keys.TEXT, text));
 	}
-
 }

test-support/src/main/java/hosh/test/support/TemporaryFolder.java

@@ -48,6 +48,9 @@ public Path toPath() {
 		return folder;
 	}
 
+	// Sonar is reporting: "Make sure publicly writable directories are used safely here."
+	// since this call is used only for tests, it is fine.
+	@SuppressWarnings("squid::S5443")
 	@Override
 	public void beforeEach(ExtensionContext context) throws Exception {
 		folder = Files.createTempDirectory("hosh-");
@@ -67,7 +70,9 @@ public Path newFile(Path parent, String fileName) throws IOException {
 
 	public Path newExecutableFile(String fileName) throws IOException {
 		Path path = newFile(folder, fileName);
-		assert path.toFile().setExecutable(true);
+		if (!path.toFile().setExecutable(true)) {
+			throw new IllegalStateException("failed to set executable bit for " + path);
+		}
 		return path;
 	}