Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-637 : KafkaAvroSerializer fails when schema.compatibility is specified in client configuration #635

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

heritamas
Copy link
Contributor

@heritamas heritamas commented Dec 4, 2019

Fixes #637

…ied in client configuration

KafkaAvroSerializer tries to initialize an Enum from a property file, without using the necessary Enum.valueOf() conversion.
This has been supplied.
Copy link
Contributor

@kamalcph kamalcph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@raju-saravanan raju-saravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @heritamas

@raju-saravanan raju-saravanan changed the title CSP-623 KafkaAvroSerializer fails when schema.compatibility is specif… ISSUE-637 : KafkaAvroSerializer fails when schema.compatibility is specified in client configuration Dec 5, 2019
@raju-saravanan
Copy link
Collaborator

@heritamas: Going forward can you create a Github issue for every PR raised? Schema Registry is an open-source project creating a Github issue for every internal JIRA would help folks in the community to know and track the changes introduced in your code.

@raju-saravanan raju-saravanan merged commit f8f80a7 into hortonworks:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KafkaAvroSerializer fails when schema.compatibility is specified in client configuration
3 participants