ISSUE-610: Provide JAAS config dynamically via config #610 #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raju-saravanan
approved these changes
Oct 23, 2019
| /** | ||
| * Configures this login instance with a dynamic configuration. | ||
| */ | ||
| public void configure(Map<String, ?> configs, String loginContextName, Configuration jaasConfiguration) { |
There was a problem hiding this comment.
Should we consider clubbing the first and the last parameter ? As in piggyback the configs specified in the map as a part of Configuration object ?
There was a problem hiding this comment.
@raju-saravanan Configuration object here is javax.security.auth.login.Configuration object and not the SR's Configuration object. Let me know if i still did not make it clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.