Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on deployment: atlantis user, atlantis comment, github app #2

Closed
lkysow opened this issue May 29, 2017 · 0 comments
Closed

Decide on deployment: atlantis user, atlantis comment, github app #2

lkysow opened this issue May 29, 2017 · 0 comments

Comments

@lkysow
Copy link
Collaborator

lkysow commented May 29, 2017

Installation Options

  • install webhook on individual repositories
  • install webhook on organization
  • install as oauth app
  • install as Github App

Can also choose between listening for comments mentioning an @atlantis user or just the string "atlantis"

Webhooks require a two step installation: create a user and then add the webhook to the repo
OAuth could be a one-step solution but we'd need to support oauth flow
I don't think Github Apps will work for Github Enterprise. CircleCI's instructions ask people to add it as an OAuth App. I haven't done a ton of research into this. Apps are nice because they automatically get a bot user associated with them, but I think it's probably over complicated for what we need.

So I think we should recommend adding as a git hook on the organization and also setting up an Atlantis user.

We could use the mentions API but I think we should still use webhooks so we can do things like auto-planning in the future (before atlantis is mentioned). We can also support both @atlantis and atlantis.

@lkysow lkysow changed the title Use an atlantis user instead of just the string "atlantis" Decide on deployment: atlantis user, atlantis comment, github app Jul 3, 2017
@lkysow lkysow added this to the Open Source Release milestone Jul 3, 2017
lkysow pushed a commit that referenced this issue Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant