Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial documentation for aftership sensor #7616

Merged
merged 3 commits into from
Dec 27, 2018
Merged

initial documentation for aftership sensor #7616

merged 3 commits into from
Dec 27, 2018

Conversation

maxandersen
Copy link
Contributor

@ghost ghost added the to-do label Nov 24, 2018
@maxandersen
Copy link
Contributor Author

I tried running rake generate but for some reason the aftership.markdown file is not being picked up so I haven't been able to verify the final result ;/

@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in a other repo and removed to-do labels Nov 25, 2018
@ghost ghost assigned frenck Nov 25, 2018
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Nov 25, 2018
@frenck
Copy link
Member

frenck commented Nov 25, 2018

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck removed their assignment Nov 26, 2018
@ghost ghost assigned fabaff Dec 27, 2018
fabaff
fabaff approved these changes Dec 27, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 996aba8 into home-assistant:next Dec 27, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@fabaff fabaff

Labels
has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxandersen @frenck @fabaff