Add Philips Moonlight Bedside Lamp support #18496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
houndci-bot
reviewed
Nov 15, 2018
| @@ -1,5 +1,5 @@ | |||
| """ | |||
| Support for Xiaomi Philips Lights (LED Ball & Ceiling Lamp, Eyecare Lamp 2). | |||
| Support for Xiaomi Philips Lights (LED Ball & Ceiling Lamp, Eyecare Lamp 2, Bedside Lamp). | |||
There was a problem hiding this comment.
line too long (90 > 79 characters)
rytilahti
approved these changes
Nov 16, 2018
| def _get_hs(rgb: int): | ||
| blue = rgb & 0xff | ||
| green = (rgb >> 8) & 0xff | ||
| red = (rgb >> 16) & 0xff |
There was a problem hiding this comment.
I think this should go preferably to python-miio (this can be then reused by the yeelight plugin, at least).
| ATTR_SLEEP_OFF_TIME = 'sleep_off_time' | ||
| ATTR_TOTAL_ASSISTANT_SLEEP_TIME = 'total_assistant_sleep_time' | ||
| ATTR_BRAND_SLEEP = 'brand_sleep' | ||
| ATTR_BRAND = 'brand' |
There was a problem hiding this comment.
These should be documented (although I saw that it's a TBD). What does brand mean in this context?
There was a problem hiding this comment.
As far as home-assistant/home-assistant.io#7498 gets merged I will extend the docs.
| @property | ||
| def max_mireds(self): | ||
| """Return the warmest color_temp that this light supports.""" | ||
| return 588 |
There was a problem hiding this comment.
I'm wondering if these should also be defined in python-miio (in kelvin, though). What do you think, does it make sense?
There was a problem hiding this comment.
Yes. We should provide specs and features in the long run by python-miio.
|
Lets wait for the next python-miio release. |
ammarfaizi2
approved these changes
Dec 1, 2018
syssi
force-pushed
the
feature/xiaomi-miio-philips-moonlight-support
branch
from
6d9a00b
to
27c9033
Compare
|
Thanks! |
thibmaek
added a commit
to thibmaek/home-assistant
that referenced
this pull request
Dec 10, 2018
…into feature/nmbs-sensor * 'dev' of https://github.com/home-assistant/home-assistant: (325 commits) Update translations Updated frontend to 20181210.0 Lovelace using storage (home-assistant#19101) Update pygtfs to upstream's 0.1.5 (home-assistant#19151) Update radiotherm to 2.0.0 and handle change in tstat error detection (home-assistant#19107) Upgrade sphinx-autodoc-typehints to 1.5.2 (home-assistant#19140) Update geizhals dependency (home-assistant#19152) Upgrade mypy to 0.650 (home-assistant#19150) Upgrade upcloud-api to 0.4.3 Upgrade youtube_dl to 2018.12.03 (home-assistant#19139) Upgrade slacker to 0.12.0 Add code support for iAlarm (home-assistant#19124) Fixed doorbird config without events (empty list) (home-assistant#19121) Remove marking device tracker stale if state is stale (home-assistant#19133) Update Google Assistant services description and request sync timeout (home-assistant#19113) update edp_redy version (home-assistant#19078) Add Philips Moonlight Bedside Lamp support (home-assistant#18496) Upgrade Mill library (home-assistant#19117) Don't avoid async_schedule_update_ha_state by returning false (home-assistant#19102) Fix the Xiaomi Aqara Cube rotate event of the LAN protocol 2.0 (Closes: home-assistant#18199) (home-assistant#19104) ...
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7589