Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude aiohappyeyeballs from license check #124041

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

joostlek
Copy link
Member

Proposed change

Exclude aiohappyeyeballs from license check as it's a valid license
https://github.com/aio-libs/aiohappyeyeballs/blob/main/LICENSE

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek requested a review from a team as a code owner August 16, 2024 10:33
@home-assistant home-assistant bot added bugfix cla-signed small-pr PRs with less than 30 lines. labels Aug 16, 2024
@joostlek joostlek merged commit 4cc4ec4 into home-assistant:dev Aug 16, 2024
40 checks passed
@joostlek joostlek deleted the aiohappyeyeballs branch August 16, 2024 11:50
@frenck frenck added this to the 2024.8.2 milestone Aug 16, 2024
@frenck frenck mentioned this pull request Aug 16, 2024
bdraco added a commit that referenced this pull request Aug 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants