Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openwebifpy to 4.2.7 #123995

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Conversation

autinerd
Copy link
Contributor

@autinerd autinerd commented Aug 15, 2024

Proposed change

This bumps openwebifpy to 4.2.7.

https://github.com/autinerd/openwebifpy/releases/tag/4.2.6
https://github.com/autinerd/openwebifpy/releases/tag/4.2.7

It would be good if this could be added to a minor release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you confirm the new code fixes the issue?
if len(result["events"]) would throw the same error when the events key isn't included, right? You're still trying to access result["events"]) that caused the issue in the first place.

If result["events"] would exist, but be empty, the previous code should already have worked. It would already return an empty dictionary then, as there's nothing to loop through. I don't think the added code fixes an actual issue.

Looking at trace in issue #123345, I think you'd have to check that the "events" key exists: "events" in result OR result.get("events") to fall-back to None (and adjust the rest of your code accordingly).

@TheJulianJES TheJulianJES marked this pull request as draft August 15, 2024 22:38
@autinerd autinerd changed the title Bump openwebifpy to 4.2.6 Bump openwebifpy to 4.2.7 Aug 16, 2024
@autinerd
Copy link
Contributor Author

Thank you, you are right. I have added the checks, so that now everything should be catched.

@autinerd autinerd marked this pull request as ready for review August 16, 2024 09:12
@joostlek joostlek added this to the 2024.8.2 milestone Aug 16, 2024
@joostlek joostlek merged commit 738cc50 into home-assistant:dev Aug 16, 2024
39 of 40 checks passed
frenck pushed a commit that referenced this pull request Aug 16, 2024
* Bump openwebifpy to 4.2.6

* Bump openwebifpy to 4.2.7

---------

Co-authored-by: J. Nick Koston <nick@koston.org>
@frenck frenck mentioned this pull request Aug 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enigma2 dead after 2024.08 update
5 participants