Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pydaikin to 2.13.4 #123623

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Bump pydaikin to 2.13.4 #123623

merged 2 commits into from
Aug 14, 2024

Conversation

kingy444
Copy link
Contributor

@kingy444 kingy444 commented Aug 11, 2024

Proposed change

Bump pydaikin to 2.13.4 to fix Daikin SSL and header regressions in Home Assistant 2024.8.1

fredrike/pydaikin@v2.13.2...v2.13.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (daikin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of daikin can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign daikin Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cremor
Copy link

cremor commented Aug 12, 2024

I suggest to handle that comment before this PR is merged: fredrike/pydaikin#16 (comment)

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea blocking this for now, because otherwise we'll introduce a problem for users with 1+ device

@home-assistant home-assistant bot marked this pull request as draft August 12, 2024 05:25
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@frenck frenck added this to the 2024.8.2 milestone Aug 12, 2024
@tofuSCHNITZEL tofuSCHNITZEL mentioned this pull request Aug 12, 2024
19 tasks
@fredrike
Copy link
Contributor

Upgrade to 2.13.4 instead..

@kingy444 kingy444 marked this pull request as ready for review August 13, 2024 22:24
@home-assistant home-assistant bot requested a review from joostlek August 13, 2024 22:24
@kingy444 kingy444 changed the title Bump pydaikin to 2.13.3 Bump pydaikin to 2.13.4 Aug 13, 2024
@joostlek joostlek merged commit cd382bc into home-assistant:dev Aug 14, 2024
35 of 36 checks passed
@joostlek
Copy link
Member

joostlek commented Aug 14, 2024

@fredrike @kingy444 @cremor Are you able to reach to me on Discord maybe?

@penso
Copy link

penso commented Aug 14, 2024

Yea blocking this for now, because otherwise we'll introduce a problem for users with 1+ device

I do have multiple devices indeed, as many users I guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.