Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump reolink-aio to 0.9.4 #120964

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Jul 1, 2024

Breaking change

Proposed change

This fixes a fairly serious issue introduced in the reolink integration in HA 2024.7.0.b0:
For a NVR that does not provide UIDs of the connected camera's the UID of channel 0 would be set to "Unknown" as is expected.
However for channels 1,2,3.. it would be wrongfully set to "Unknown_1", "Unknown_2", "Unknown_3".......
This would cause the integration to think those cams have a UID and the unique_ids of those camera's would wrongfully be migrated to use the "UID", "Unknown_1" in the unique_id. That will cause a mess in the integration.

Bump reolink-aio to 0.9.4:
Additions:

Bug fixes:

Optimizations:

Full Changelog: starkillerOG/reolink_aio@0.9.3...0.9.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek joostlek merged commit 2d054fb into home-assistant:dev Jul 2, 2024
39 checks passed
@starkillerOG starkillerOG deleted the reolink_bump094 branch July 2, 2024 07:27
frenck pushed a commit that referenced this pull request Jul 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants