Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This fixes a fairly serious issue introduced in the reolink integration in HA 2024.7.0.b0:
For a NVR that does not provide UIDs of the connected camera's the UID of channel 0 would be set to "Unknown" as is expected.
However for channels 1,2,3.. it would be wrongfully set to "Unknown_1", "Unknown_2", "Unknown_3".......
This would cause the integration to think those cams have a UID and the unique_ids of those camera's would wrongfully be migrated to use the "UID", "Unknown_1" in the unique_id. That will cause a mess in the integration.
Bump reolink-aio to 0.9.4:
Additions:
Bug fixes:
Optimizations:
Full Changelog: starkillerOG/reolink_aio@0.9.3...0.9.4
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: