Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESPHome] Disable dashboard based update entities by default #120907

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

jesserockz
Copy link
Member

Breaking change

Proposed change

These dashboard based update entities were overwhelming users that had many ESPHome devices on their network. There is no reason that every device needs to be fully up to date with the latest ESPHome release if it is in a working state and there are no vulnerabilities that have been fixed in recent releases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 1, 2024

Hey there @OttoWinter, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@frenck
Copy link
Member

frenck commented Jul 1, 2024

Converting this PR to draft for now, I think we need to discuss the approach here first.

As this is trying to manage a UI issue.

../Frenck

@balloob
Copy link
Member

balloob commented Jul 2, 2024

Discussed offline and good to go.

@balloob balloob marked this pull request as ready for review July 2, 2024 11:44
@frenck frenck added this to the 2024.7.0 milestone Jul 2, 2024
@frenck frenck merged commit 72d706a into dev Jul 2, 2024
25 checks passed
@frenck frenck deleted the jesserockz-2024-266 branch July 2, 2024 11:51
frenck pushed a commit that referenced this pull request Jul 2, 2024
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@felipecrs
Copy link
Contributor

How are users supposed to update their devices now? Through the ESPHome Dashboard?

I am just bringing this point because the update entities, although overwhelming 90% of the times, were helpful when I finally decided to update my devices.

I could simply click in Update in each one and leave them running. It would take an hour but everything would end up being updated, whereas in the dashboard I can only do one at a time, and I need to keep monitoring it.

@balloob
Copy link
Member

balloob commented Jul 2, 2024

You can still enable the entities if you want. You can also in the dashboard use the "Update All" feature, to avoid having to do many clicks.

The reasoning here is that we are no longer emphasizing the constant updates for ESPHome devices. A minor patch release of ESPHOMe doesn't require a whole rebuild of your device as most likely, it won't run any new code.

@felipecrs
Copy link
Contributor

That makes sense and sounds like a good compromise.

As a user, I totally support it. It also gives me a bit more peace of mind regarding the number of flashes my ESP devices can still take.

@cociweb
Copy link

cociweb commented Jul 3, 2024

Unfortunatelly, I have more Offline/Draft devices than online (eg. multiple dev variant for a device) The 'Update all' button tries to recompile those offline devices as well. As of now it would be nice for the user to mark them as 'Draft' or 'Out of use' to keep tidy the dashboard and don't recompile them unnecessarily...

@felipecrs
Copy link
Contributor

Yeah, now I remember why Update all wasn't useful for me. Also, I think you had to keep the dashboard open in your browser all the time otherwise it would stop the update process, if I remember well.

@alexruffell
Copy link

You can also in the dashboard use the "Update All" feature, to avoid having to do many clicks.

I have over 50 nodes and "Update All" 100% never finishes updating my nodes. For some unknown reason it fails after just a few nodes. Starting it over starts from scratch as far as I recall so I am left with triggering updates manually. I now have a node-red flow that triggers the updates by category with me just pressing the button for whatever category I want to update.

@felipecrs
Copy link
Contributor

Right, in short, Update all button in the ESPHome Dashboard hasn't much use.

But anyway, we can just re-enable the update entities. This is simple enough.

@home-assistant home-assistant locked and limited conversation to collaborators Jul 4, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants