Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AEMET-OpenData to v0.5.2 #120065

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Jun 21, 2024

Proposed change

Update AEMET-OpenData to v0.5.2.
This fixes an API change introduced by AEMET which breaks the integration.

Releases:

Git compare: Noltari/AEMET-OpenData@0.5.1...0.5.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2024
Copy link
Contributor

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @Noltari!

@Noltari
Copy link
Contributor Author

Noltari commented Jun 21, 2024

Failure in test coverage upload not related to changes
https://github.com/home-assistant/core/actions/runs/9609869516/job/26505974192?pr=120065

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Noltari 👍

@edenhaus edenhaus merged commit f30b20b into home-assistant:dev Jun 21, 2024
34 of 35 checks passed
@Noltari Noltari deleted the aemet-v0.5.2 branch June 21, 2024 09:12
@Noltari
Copy link
Contributor Author

Noltari commented Jun 21, 2024

@edenhaus can we add this to 2024.6.4?

@edenhaus edenhaus added this to the 2024.6.4 milestone Jun 21, 2024
frenck pushed a commit that referenced this pull request Jun 21, 2024
@frenck frenck mentioned this pull request Jun 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cherry-picked cla-signed dependency integration: aemet Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AEMET "unknown error ocurred" trying to add/configure the integration
4 participants