Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump brother library, use pysnmp-lextudio with SNMP integration #105591

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Bump brother library, use pysnmp-lextudio with SNMP integration #105591

merged 4 commits into from
Dec 12, 2023

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Dec 12, 2023

Breaking change

Proposed change

Currently, SNMP integration and brother library use this pysnmp fork, which is not compatible with python 3.12 and is rarely updated. The author of the original pysnmp library has passed away.
I suggest changing the library for snmp integration and brother library to pysnmp-lexstudio, which is compatible with python 3.12.

I tested HA running under python 3.12 and both brother integration and snmp sensor work fine.

brother changelog: bieniu/brother@2.3.0...3.0.0
pysnmp-lextudio repo: https://github.com/lextudio/pysnmp

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Dec 12, 2023

I'll test it shortly.

It seems reasonable to me as otherwise we have no snmp support shortly once we go to py3.12

@bdraco
Copy link
Member

bdraco commented Dec 12, 2023

@bdraco
Copy link
Member

bdraco commented Dec 12, 2023

Wheels look ok. Tested on my production where I use snmp but not brother and all is working as expected 👍

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bieniu

Looks like that brings us down to only 4 integrations that don't support 3.12 and thankfully they almost all have anemic usage except for metoffice

@bdraco bdraco merged commit 7728370 into home-assistant:dev Dec 12, 2023
72 of 74 checks passed
@bieniu bieniu deleted the snmp-brother branch December 12, 2023 21:40
@bieniu
Copy link
Member Author

bieniu commented Dec 12, 2023

Thanks @bdraco

@cdce8p cdce8p mentioned this pull request Dec 12, 2023
28 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants