Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Significantly reduce heartbeat overhead (#301)" #611

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 8, 2024

This reverts commit e3020ff.

This change is no longer needed after aio-libs/aiohttp#8608

closes #610

@bdraco bdraco marked this pull request as ready for review August 8, 2024 19:35
Copy link
Contributor

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think it worth waiting for #613 since we might release a bugfix before that.

Copy link
Collaborator

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with real device, works as intended.

@bieniu bieniu merged commit df22e28 into main Aug 11, 2024
2 checks passed
@bieniu bieniu deleted the revert_ping_pong branch August 11, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert #301 once aiohttp timer handle churn is reduced
3 participants