Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple process_waits_in checks identically to a single check #190

Closed
mmiikkkkaa opened this issue Jun 7, 2023 · 0 comments · Fixed by #191
Closed

Handle multiple process_waits_in checks identically to a single check #190

mmiikkkkaa opened this issue Jun 7, 2023 · 0 comments · Fixed by #191
Assignees
Labels
Type: enhancement New feature or request
Milestone

Comments

@mmiikkkkaa
Copy link
Contributor

The process_waits_in method exists in two overloaded variantes: with a single activityId and with multiple activityIds.

The current implementation of the multiple activityIds variant causes problems due to not finding the "job", while the single activityId variant works. The multiple activityId variant might use the same operation as the single activityId variant, this would eliminiate the problems.

BTW: Since the multiple activityIds uses varargs it automatically covers the single activityId variant. Therefore the single variant can be removed completely.

@mmiikkkkaa mmiikkkkaa added the Type: enhancement New feature or request label Jun 7, 2023
@zambrovski zambrovski added this to the 0.4.2 milestone Jun 7, 2023
zambrovski added a commit that referenced this issue Oct 9, 2023
…aits_in-checks-identically-to-a-single-check

feat(#190): unify process_waits_in checks for single and multiple acitivities
@zambrovski zambrovski modified the milestones: 0.4.2, 1.19.0 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
2 participants