Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Ignore warnings in documentation #7344

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

docs: Ignore warnings in documentation #7344

wants to merge 1 commit into from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 29, 2024

I'm not sure if we ignore warnings with the current setup. If we don't currently ignore warnings, we could add this environment variable so warnings are not shown in documentation. If we do ignore them, this PR can be closed.

xref: holoviz-dev/nbsite#312

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (d39874c) to head (2a38616).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7344      +/-   ##
==========================================
- Coverage   82.21%   82.21%   -0.01%     
==========================================
  Files         337      337              
  Lines       50503    50503              
==========================================
- Hits        41521    41520       -1     
- Misses       8982     8983       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ignore them for the prod build but leave them for the dev build?

@hoxbro
Copy link
Member Author

hoxbro commented Oct 1, 2024

I have second thoughts about this PR, so I will mark it as a draft.

@hoxbro hoxbro marked this pull request as draft October 1, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants