Use Cargos fingerprint data to trim to only install rust versions #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks very good, however, it seems to be crashing on Linux environment. Is rustup not available on Travis for Linux systems I wonder? Or is it something obvious I am missing? |
|
Looks like rustup is available in travisce, maybe it has something to do with cross? If we can't get the tests to work on CI, we can just remove them, they are not testing very much. (it makes me feel dirty to say it.) |
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Dec 21, 2018
don't write a an incorrect rustc version to the fingerprint file In making holmgr/cargo-sweep#14 I noted that some fingerprint files related to build scripts report being built with a rustc that hashes to "0". To work around this I just marked them as still being needed, even though no rustc that hashes to "0" is currently installed. I believe that this PR just filles in the correct info for the build script fingerprints. This makes it possible for outside tools to more reliably clean up after cargo, at basically no cost. @ehuss Thanks again for the help.
|
I removed the tests. They were only testing that reading the data from rustup was not crashing. And that is not a particularly finicky part of the code. |
This was referenced Dec 23, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR discussed in #6 (comment), specifically it used cargos fingerprint files and folder structure to let you
cargo +stable build && cargo +nightly build && rustup toolchain remove nightly && cargo sweep -iand it will remove all the files related to nightly leaving you with the same files as if you had only runcargo +stable build. (Witch a lot of peepal need to clean the cache folder on CI when nightly updates. like rust-lang/crates.io#1578)