Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make delete a top level command #89

Merged
merged 3 commits into from
Aug 18, 2013
Merged

Conversation

eugeneius
Copy link
Contributor

Most boom commands are passed as the first argument, with the list or item coming after:

boom urls github "https://github.com"
boom echo github
boom random urls
boom open github

Until recently, delete was an odd duck - it was passed after the list/item:

boom urls github delete #boo

As part of the 0.3.0 release, the syntax for deleting an item was changed to be less ambiguous:

boom github --delete #hmm

I think putting delete first, like all of the other commands, makes things even clearer:

boom delete urls github #yay

This is something I was considering a while ago, but I didn't want to break existing behaviour. Since 0.3.0 already did that, now is probably the best time to think about making this change.

@holman
Copy link
Owner

holman commented Aug 18, 2013

I was typing out a rebuttal to this but there's enough other counter-examples — boom open, etc — to where it makes sense. Let's do it.

holman added a commit that referenced this pull request Aug 18, 2013
Make delete a top level command
@holman holman merged commit 190b8eb into holman:master Aug 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants