Always show error message on failed ajax requests #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If misterhouse is run behind web proxy (tested with nginx), ajax requests may be answered with an html error page if misterhouse is not running. In this case no valid JSON is returned. This fix simply catches the JSON parse exception and adds http status + text to the system message. Before, the message was never shown because the exception was not handled.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If misterhouse is run behind web proxy (tested with nginx), ajax
requests may be answered with an html error page if misterhouse is not
running. In this case no valid JSON is returned. This fix simply catches
the JSON parse exception and adds http status + text to the system
message. Before, the message was never shown because the exception was not
handled.