Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doorbird documentation updates. #634

Merged
merged 7 commits into from
Oct 23, 2016
Merged

Doorbird documentation updates. #634

merged 7 commits into from
Oct 23, 2016

Conversation

waynieack
Copy link
Contributor

DOORBIRD.pm now has documentation that converts to HTML properly and can be viewed in the local Misterhouse POD documentation page.
DOORBIRD.pm has been updated to post back to Misterhouse using the no_response option.
Code has been run through perl tidy to clean up formatting.

@hollie
Copy link
Owner

hollie commented Oct 23, 2016

Hmm, weird why this would cause the regression test to fail. It seems to me that the web service that is used in the get_url regression test was not working fine.

I'll see to make the test more verbose so that we can see what is actually wrong and try to update this pull request.

@hollie
Copy link
Owner

hollie commented Oct 23, 2016

My pull request did not make any changes to the code, but the tests now work fine. This confirms that the failure was due to the server that is accessed during the test was not working fine and that the MisterHouse code is still working as expected. Merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants