Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed object declarations that were split over two lines as a result … #575

Closed
wants to merge 2 commits into from

Conversation

hplato
Copy link
Collaborator

@hplato hplato commented Mar 2, 2016

…of Perltidy

@hollie
Copy link
Owner

hollie commented Mar 20, 2016

Hey Howard,

if OK for you I'd like to hold this merge until we're sure on if we actually want to manually fix files after a perltidy run. If we can fix the parser or the code then we might not need to manually intervent with code formatting anymore.

Best regards,
Lieven.

@hollie
Copy link
Owner

hollie commented Sep 26, 2016

Hello Howard,

what do you think, is this fixed already or should we still look into this?

Regards,
Lieven.

@hplato
Copy link
Collaborator Author

hplato commented Sep 27, 2016

If the travis CI has been working, let’s close this. Once master is updated and we’re testing 4.2, we can test some of the problematic common code modules (I think BSC was one of them)

On Sep 26, 2016, at 1:48 PM, Lieven Hollevoet notifications@github.com wrote:

Hello Howard,

what do you think, is this fixed already or should we still look into this?

Regards,
Lieven.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #575 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AExbSLVZfKcZ2thjKIUaLxNVJUNH5pd2ks5quCF1gaJpZM4Hm_2P.

@hollie
Copy link
Owner

hollie commented Sep 27, 2016

Hello Howard,

Ok I agree with you. Closing this one and let's see where we get with testing on 4.2.

Thanks,
Lieven.

@hollie hollie closed this Sep 27, 2016
@hplato hplato deleted the perltidy_object_fixes branch March 17, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants