Plcbus support #529
Merged
Plcbus support #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
June 16, 2015 20:12
instead of setting the state before even sending the request...
…into plcbus-master
REPRQ is not set when the command is repeated by the phasecoupler.
Move PLCBUS all Voice_Cmds into Category PLCVBUS instead of Groups. Do not force modules into predefinde groups. Use $self->... everywhere. Add more voice commands to configure 'presetdim' of modules.
also move all PLCBUS items into PLCBUS.pm
only set state if status_on/off was received fix logging
Prevents sending more commands as long as the previos was not completed make last_data_to_from_bus instance variable
also handle report_all_id_pulse reply and do not wait for status_on/off if request
|
Hello, any remarks on the $additional_code update in lib/read_table_A.pl? If not, looks OK for merging to me. Best regards, |
|
Small update required for users who don't use PLCBUS, see #558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding PLCBus support from the repo of @tobser.