xPL messages generate invalid msg-type #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Generic_Item code is calling sendXpl with the message type of "xpl-stat", however sendXpl adds the xpl- prefix as well, resulting in an invalid message type.
|
Hey George, can you please tell me how to enable the behavior of MisterHouse to send the xpl messages? Then I can try this out. Thanks, |
|
Verified on my MisterHouse setup that this bug fix does not break existing xPL messaging. Going to merge it in master. |
hollie
added a commit
that referenced
this pull request
Mar 15, 2014
xPL messages generate invalid msg-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Generic_Item code is calling sendXpl with the message type of
"xpl-stat", however sendXpl adds the xpl- prefix as well, resulting in
an invalid message type.
The xPL4Linux hub appears to reject the message because of a missing Device ID. I'm not sure if that's a hub issue or something with the generated message.