Update debug to note I2CS devices as potential sources of error #31
Conversation
Merge branch 'master' of https://github.com/hollie/misterhouse
Previously, insteon cleanup messages received by MH, would cause MH to clear the active message withoug confirming if the cleanup message corresponded to the active message. If multiple PLM scenes were sent sequentially, a cleanup message from one scene may have caused MH to clear out the following scenes command. This patch only clears the active message if the cleanup message matches the active message.
Add a conditional check for the file 1100tags.txt. If it doesn't exist in the user defined data directory, then default to the Pgm_root/data directory.
An I2CS device will respond with a NACK if you try and control it with the PLM before it is linked as a responder. Add a note to the debug log regarding this.
Based on Marc Merlin's code, I confirmed that I received the same error. More issues with #28 still need to be solved.
|
Hi Kevin, thanks for the pull requests. I will apply them. A small remark/question from my side to make the repository maintenance more easy: if you fix different issues, could you please do so in a different branch in your repo? As you can see now, both the issue #26 and #27 are applied in the same pull request. This is due to the fact that you fixed them both in the same branch. The fix for #27 I can merge right away (because I can test it). The fix for #26 I cannot test, so I prefer others to test before merging. Right now I cannot just accept the pull request as is because it would apply both fixes in one go. Please don't take this as criticism, it is just a suggestion to make the job of pulling fixes into master more easy. Thanks for the fixes! Op 20-dec.-2012, om 23:07 heeft krkeegan notifications@github.com het volgende geschreven:
|
|
I realized after the fact that this may be an issue. I will do my best. |
These are likely causing some unnoticed error.
|
Hollie: So it would have been better if those had been separate pull requests, but assuming the couple of modules that grew a newline at the end aren't a big deal, would it be ok to pull this all in with the understanding that next time those changes should be split up? |
|
Oh, my. that is a horrible bug in AllLinkDatabase.pm. I duplicated those bugs in the i2 support :0 |
No description provided.