Insteon fix to correctly sync links when off_fast is used #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insteon::BaseInsteon::sub derive_link_state() defaulted to "on" as the link state if it didn't understand the link state. "Off_fast" is a valid link state and should be recognized as equivalent to off instead of defaulting to on.
hollie
added a commit
that referenced
this pull request
Dec 15, 2012
Insteon fix to correctly sync links when off_fast is used. Merged after Jim confirmed this is working.
hplato
pushed a commit
that referenced
this pull request
Feb 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insteon::BaseInsteon::sub derive_link_state() defaulted to "on" as the link state if it didn't
understand the link state. "Off_fast" is a valid link state and should be recognized as
equivalent to off instead of defaulting to on.