Add xPL x10 basic support (input from Roger on mailing list) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is based on an email that was sent on the list. The original developer is Roger Simon. I only did basic testing on this code (as in: I added an item in my mht file and saw it showed up in the web interface and it didn't crash misterhouse). I think this code is missing default on/off states for X10Basic items?
Confirmed that with the proposed syntax in the mht file the following message is generated when $device->send_on() is called: [xpl-cmnd/x10.basic: mhouse-mh.misterhouse -> hollie-x10gate.downstairs - on uplight]
hollie
added a commit
that referenced
this pull request
Apr 14, 2013
Add xPL x10 basic support (input from Roger on mailing list)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I send in this pull request after Roger requested to commit his proposed change to support x10basic xPL messages.
The only change I made compared to the input from Roger is that I added the code so a separate file. In my opinion, adding everything to xPL_Items.pm does not help in keeping the code structured and maintainable.
I did some basic testing on this code, however, I don't have actual hardware to test this on. I think the code is missing a bit that allows you to click an item in the web interface to toggle its status. Now you really need to call $item->send_on() to cause the xPL message to be generated.