Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xPL messages from devices with spaces in their names are not processed properly #77

Closed
hollie opened this issue Feb 14, 2013 · 1 comment
Labels

Comments

@hollie
Copy link
Owner

hollie commented Feb 14, 2013

Roger noticed that after reverting the xPL regexp to the old value in #11 messages for device that have spaces in their names don't longer work.

I'll look into fixing this during the weekend.

@hollie
Copy link
Owner Author

hollie commented Mar 17, 2013

To be more clean, it is not the device name that has a space in it, but the values of key/value pairs. See also #10

hollie added a commit that referenced this issue Mar 17, 2013
In #10 I reverted a change in the xPL message parsing because it apparently caused the xPL processing of messages to stop working. In #10 I had the impression that the change was required to allow MisterHouse to support unsupported messages to be processed.
However, I was wrong there. I misinterpreted the xPL spec. When a message is created, it contains key/value pairs. Only the name of a key/value pair cannot contain a space. The value can. This fix enables processing of messages with spaces in the value of key/value pairs to be processed again.
@hollie hollie closed this as completed Mar 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant