Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add_Link Fails to Change ALDB Health from Empty to Good #59

Closed
krkeegan opened this issue Feb 6, 2013 · 2 comments
Closed

Add_Link Fails to Change ALDB Health from Empty to Good #59

krkeegan opened this issue Feb 6, 2013 · 2 comments
Assignees
Labels

Comments

@krkeegan
Copy link
Collaborator

krkeegan commented Feb 6, 2013

To reproduce:

  1. Factory Reset a Device
  2. Scan Device
  3. Sync Device
  4. Log Links

MH will now print that the link table is empty. This is because add_link has failed to update the health of the link table.

@ghost ghost assigned krkeegan Feb 6, 2013
krkeegan added a commit to krkeegan/misterhouse that referenced this issue Feb 6, 2013
If we can add a link, the ALDB health cannot be corrupt.  If aldb health is not updated to good from empty, log links will never print the link table.

Fixes hollie#59
@krkeegan krkeegan closed this as completed Feb 6, 2013
@mstovenour
Copy link
Collaborator

Is there a reason to have the “empty” state at all?

From: krkeegan [mailto:notifications@github.com]
Sent: Tuesday, February 05, 2013 10:22 PM
To: hollie/misterhouse
Subject: [misterhouse] Add_Link Fails to Change ALDB Health from Empty to Good (#59)

To reproduce:

  1. Factory Reset a Device
  2. Scan Device
  3. Sync Device
  4. Log Links

MH will now print that the link table is empty. This is because add_link has failed to update the health of the link table.


Reply to this email directly or view it on GitHub #59 .

https://github.com/notifications/beacon/Jshd8sI44GVrKZBvymxqKLOCVqkCsK6Ij2xrsX-v4reTbh90cstrIwotECSMhsyp.gif

@krkeegan
Copy link
Collaborator Author

krkeegan commented Feb 6, 2013

Umm, that is a good question. I was focused more on solving the issue than
figuring out the code.

The only thing I see that truly relies on health eq 'empty' is Log_Links.
Everything else seems to look for health eq 'empty' || 'good' I see no
reason to keep it around.

On Wed, Feb 6, 2013 at 10:30 AM, Michael Stovenour <notifications@github.com

wrote:

Is there a reason to have the “empty” state at all?

From: krkeegan [mailto:notifications@github.com]
Sent: Tuesday, February 05, 2013 10:22 PM
To: hollie/misterhouse
Subject: [misterhouse] Add_Link Fails to Change ALDB Health from Empty to
Good (#59)

To reproduce:

  1. Factory Reset a Device
  2. Scan Device
  3. Sync Device
  4. Log Links

MH will now print that the link table is empty. This is because add_link
has failed to update the health of the link table.


Reply to this email directly or view it on GitHub <
https://github.com/hollie/misterhouse/issues/59> .

<
https://github.com/notifications/beacon/Jshd8sI44GVrKZBvymxqKLOCVqkCsK6Ij2xrsX-v4reTbh90cstrIwotECSMhsyp.gif>


Reply to this email directly or view it on GitHubhttps://github.com//issues/59#issuecomment-13197198.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants