Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tuning: 20% improvements for simple put operations #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yjh0502
Copy link

@yjh0502 yjh0502 commented Jul 10, 2013

I tuned some function in critical path.

  • Change fmt.Sprintf to bytes.Buffer
  • Change string operations to byte operations
  • Change default buffer size to handle small-sized request better

These update shows 20% improvement for simple set operations. See following link for detail: https://docs.google.com/spreadsheet/ccc?key=0AjFZD5XgU6lFdEhPS21Pd0lpYjFKcGJLalRCdG9UZ3c#gid=0

@codeskyblue
Copy link

great

1 similar comment
@sunminghong
Copy link

great

@hoisie
Copy link
Owner

hoisie commented Mar 19, 2014

This looks great, but it needs a merge with master - are you available to do it?

@yjh0502
Copy link
Author

yjh0502 commented Mar 20, 2014

@hoisie I'll merge the patch with master, but not right now because I don't have a spare time right now. It may takes some time, maybe several days. I'll update this PR after merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants