Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

CI: Set up Travis #67

Merged
merged 4 commits into from
Dec 27, 2017
Merged

CI: Set up Travis #67

merged 4 commits into from
Dec 27, 2017

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Mar 7, 2017


script:
- composer install
- vendor/bin/hoa test:run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we add travis_wait for this step while using xdebug due to latency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tried for hoa/json but it takes too long…

@mfn
Copy link

mfn commented Dec 26, 2017

Hi,
what is needed to move forward with this?

From looking at the latest travis builds:

  • 5.5 fails => but is this still relevant? It has reached EOL 1 1/2 years ago
  • 7.1 with xdebug fails => seems like a timeout, it's known (and also mentioned above) that it slows PHP down too much at times

@Hywan
Copy link
Member Author

Hywan commented Dec 27, 2017

5.5 has been dropped, and for 7.1, yes, xdebug makes it fail unfortunately because of a timeout. Maybe we will drop ENABLE_XDEBUG for this test matrix.

@Bhoat Bhoat merged commit 1b66842 into hoaproject:master Dec 27, 2017
@ghost ghost removed the in progress label Dec 27, 2017
@mfn
Copy link

mfn commented Dec 27, 2017

Thank you 😄

SerafimArts added a commit to railt/compiler that referenced this pull request Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

5 participants