Check syntax of loopback interface

Changes

@@ -1,6 +1,7 @@
 {{$NEXT}}
 
  - Removed support for EZVPN at Cisco devices.
+ - Syntax of loopback interfaces is checked more thoroughly.
 
 6.065     2023-11-13 11:45:12+01:00 Europe/Berlin
 

go/pkg/pass1/setup-objects.go

@@ -1708,6 +1708,7 @@ func (c *spoc) setupInterface(v *ast.Attribute,
 		check(intf.owner != nil, "owner")
 		check(intf.loopback, "loopback")
 		check(vip, "vip")
+		intf.loopback = false
 	} else if vip {
 		// Attribute 'vip' is an alias for 'loopback'.
 		typ = "'vip'"
@@ -1853,6 +1854,9 @@ func (c *spoc) setupInterface(v *ast.Attribute,
 
 	// Automatically create a network for loopback interface.
 	if intf.loopback {
+		if !isSimpleName(nName) {
+			c.err("Invalid identifier in '%s' of '%s'", v.Name, r.name)
+		}
 		var shortName string
 		var fullName string
 

go/testdata/ipv6/parser_ipv6.t

@@ -738,6 +738,17 @@ Error: Can't resolve interface:r1.n1@vrf2 in user of service:s1
 Error: Can't resolve interface:r.n.123.nn in user of service:s1
 =END=
 
+############################################################
+=TITLE=Invalid name of loopback interface
+=PARAMS=--ipv6
+=INPUT=
+router:r1 = {
+ interface:lo-::a01:203 = { ip = ::a01:203; loopback; }
+}
+=ERROR=
+Error: Invalid identifier in 'interface:lo-::a01:203' of 'router:r1'
+=END=
+
 ############################################################
 =TITLE=Missing [any|all]
 =TODO= No IPv6

go/testdata/parser.t

@@ -679,6 +679,16 @@ Error: Can't resolve interface:r1.n1@vrf2 in user of service:s1
 Error: Can't resolve interface:r.n.123.nn in user of service:s1
 =END=
 
+############################################################
+=TITLE=Invalid name of loopback interface
+=INPUT=
+router:r1 = {
+ interface:lo-10.1.2.3 = { ip = 10.1.2.3; loopback; }
+}
+=ERROR=
+Error: Invalid identifier in 'interface:lo-10.1.2.3' of 'router:r1'
+=END=
+
 ############################################################
 =TITLE=Missing [any|all]
 # No IPv6