Skip to content

Commit

Permalink
Minor simplification
Browse files Browse the repository at this point in the history
  • Loading branch information
hknutzen committed Feb 28, 2024
1 parent 39a1666 commit 2d7adb9
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions go/pkg/pass1/check-service-owner.go
Original file line number Diff line number Diff line change
Expand Up @@ -282,26 +282,26 @@ func (c *spoc) checkServiceOwner(sRules *serviceRules) {
// Check if attribute 'multi_owner' could be avoided,
// if objects of user and objects of rules are swapped.
var userOwner *owner
simpleUser := true
USERS:
for _, users := range info.users {
for _, user := range users {
var o *owner
if obj, ok := user.(srvObj); ok {
o = obj.getOwner()
}
if o == nil {
simpleUser = false
break
userOwner = nil
break USERS
}
if userOwner == nil {
userOwner = o
} else if userOwner != o {
simpleUser = false
break
userOwner = nil
break USERS
}
}
}
if simpleUser && userOwner != nil {
if userOwner != nil {
c.warn("Unnecessary 'multi_owner' at %s\n"+
" All 'user' objects belong to single %s.\n"+
" Either swap objects of 'user' and objects of rules,\n"+
Expand Down

0 comments on commit 2d7adb9

Please sign in to comment.