Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro SubsetRelationshipInspector #99

Merged
merged 9 commits into from
Jan 6, 2024
Merged

Conversation

Wh1isper
Copy link
Collaborator

@Wh1isper Wh1isper commented Jan 5, 2024

Description

Motivation and Context

  • Move RelationshipInspector as base class
  • Intro SubsetRelationshipInspector as default RelationshipInspector
  • Some bug fix and improvment

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Wh1isper Wh1isper added this to the 0.2.0 milestone Jan 5, 2024
Copy link
Contributor

sweep-ai bot commented Jan 5, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@Wh1isper Wh1isper modified the milestones: 0.2.0, 1.0.0, 2.0.0 Jan 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9bf075a) 78.68% compared to head (dd399cd) 79.32%.

Files Patch % Lines
sdgx/data_models/inspectors/base.py 81.81% 2 Missing ⚠️
sdgx/data_models/inspectors/subset_relationship.py 97.43% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   78.68%   79.32%   +0.64%     
==========================================
  Files          59       59              
  Lines        2463     2496      +33     
==========================================
+ Hits         1938     1980      +42     
+ Misses        525      516       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wh1isper Wh1isper marked this pull request as ready for review January 5, 2024 08:18
@Wh1isper Wh1isper requested a review from MooooCat January 5, 2024 08:19
@Wh1isper Wh1isper changed the title Implementing DefaultRelationshipInspector Implementing SubsetRelationshipInspector Jan 5, 2024
@Wh1isper Wh1isper changed the title Implementing SubsetRelationshipInspector Intro SubsetRelationshipInspector Jan 5, 2024
@Wh1isper Wh1isper enabled auto-merge (squash) January 5, 2024 08:29
@Wh1isper Wh1isper added the enhancement New feature or request label Jan 5, 2024
@Wh1isper Wh1isper merged commit c10270f into main Jan 6, 2024
11 checks passed
@Wh1isper Wh1isper deleted the feature-relationship-inspector branch January 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants