Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo data for multi-table scenario #98

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Conversation

MooooCat
Copy link
Contributor

@MooooCat MooooCat commented Jan 4, 2024

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

sweep-ai bot commented Jan 4, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@MooooCat
Copy link
Contributor Author

MooooCat commented Jan 4, 2024

At present, the code of demo data is located in utils.py. I found that importing metadata in the implementation of utils.py will lead to circular import.

I recommend moving these implementations to a new file, such as dataset/demo.py, to make the functions of each module more clear.

What do you think of this solution? @Wh1isper

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (c10270f) 79.32% compared to head (19f21b1) 78.59%.

Files Patch % Lines
sdgx/utils.py 14.28% 24 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   79.32%   78.59%   -0.74%     
==========================================
  Files          59       59              
  Lines        2496     2523      +27     
==========================================
+ Hits         1980     1983       +3     
- Misses        516      540      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wh1isper
Copy link
Collaborator

Wh1isper commented Jan 4, 2024

Moving demo Metadata into a single file will be better. This represents the user's preprocessing, not our utils.

@MooooCat
Copy link
Contributor Author

MooooCat commented Jan 4, 2024

Moving demo Metadata into a single file will be better. This represents the user's preprocessing, not our utils.

It makes sense, building metadata belongs to user process.

The function get_demo_multi_table will return multi DataFrame like get_demo_single_table, without Metadata.

@Wh1isper Wh1isper added this to the 0.2.0 milestone Jan 5, 2024
@MooooCat MooooCat marked this pull request as ready for review January 8, 2024 06:43
@MooooCat MooooCat requested a review from Wh1isper January 8, 2024 06:43
Copy link
Collaborator

@Wh1isper Wh1isper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Wh1isper Wh1isper merged commit 9479c1b into main Jan 8, 2024
11 checks passed
@Wh1isper Wh1isper deleted the data-multitable-demo-date branch January 8, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants