-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo data for multi-table scenario #98
Conversation
for more information, see https://pre-commit.ci
Apply Sweep Rules to your PR?
|
At present, the code of demo data is located in utils.py. I found that importing metadata in the implementation of utils.py will lead to circular import. I recommend moving these implementations to a new file, such as dataset/demo.py, to make the functions of each module more clear. What do you think of this solution? @Wh1isper |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 79.32% 78.59% -0.74%
==========================================
Files 59 59
Lines 2496 2523 +27
==========================================
+ Hits 1980 1983 +3
- Misses 516 540 +24 ☔ View full report in Codecov by Sentry. |
Moving demo |
It makes sense, building metadata belongs to user process. The function |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Description
Motivation and Context
How has this been tested?
Types of changes
Checklist: