-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MetadataCombiner, partitial refactoring on Metadata #96
Conversation
Apply Sweep Rules to your PR?
|
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 75.68% 76.63% +0.95%
==========================================
Files 58 59 +1
Lines 2274 2435 +161
==========================================
+ Hits 1721 1866 +145
- Misses 553 569 +16 ☔ View full report in Codecov by Sentry. |
Still remaning work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
(Maybe we should add more demo data for multi-table scenario, I can start a issue and work on it.)
I'll be introducing some very simple mock data to use as unit tests, @MooooCat please help us gather some real multi-table scenario data to introduce into the project, like the current adult.csv. |
Description
Motivation and Context
RelationshipInspector
for building relations.MetadataCombiner
frameworkMetadata
How has this been tested?
Types of changes
Checklist: