Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro torchrun in CLI #88

Merged
merged 6 commits into from
Dec 29, 2023
Merged

Intro torchrun in CLI #88

merged 6 commits into from
Dec 29, 2023

Conversation

Wh1isper
Copy link
Collaborator

@Wh1isper Wh1isper commented Dec 27, 2023

Description

This is an experimental feature that introduces torchrun for native supporting PyTorch distributed training.

Alternative: torchrun $(which sdgx)

Motivation and Context

How has this been tested?

Manually, as wrapper is not compatible with click.testing.CliRunner

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

sweep-ai bot commented Dec 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (76e3eb0) 76.27% compared to head (d5269cb) 75.68%.

Files Patch % Lines
sdgx/cli/utils.py 42.85% 20 Missing ⚠️
sdgx/utils.py 50.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   76.27%   75.68%   -0.60%     
==========================================
  Files          58       58              
  Lines        2230     2274      +44     
==========================================
+ Hits         1701     1721      +20     
- Misses        529      553      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wh1isper Wh1isper enabled auto-merge (squash) December 28, 2023 03:47
@Wh1isper Wh1isper merged commit 00ba7f1 into main Dec 29, 2023
11 checks passed
@Wh1isper Wh1isper deleted the feature-cli-torchrun branch December 29, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants