Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI for singe table synthesizer #86

Merged
merged 16 commits into from
Dec 23, 2023
Merged

CLI for singe table synthesizer #86

merged 16 commits into from
Dec 23, 2023

Conversation

Wh1isper
Copy link
Collaborator

@Wh1isper Wh1isper commented Dec 21, 2023

Description

Motivation and Context

  • Intro Data Exporter for exporting sampled data to data sources
  • CLI updates for synthesizer

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

sweep-ai bot commented Dec 21, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (bedd69c) 71.20% compared to head (39d9159) 76.19%.

Files Patch % Lines
sdgx/cli/main.py 79.41% 21 Missing ⚠️
sdgx/cli/utils.py 72.72% 6 Missing ⚠️
sdgx/synthesizer.py 71.42% 4 Missing ⚠️
sdgx/data_exporters/csv_exporter.py 88.46% 3 Missing ⚠️
sdgx/data_exporters/base.py 83.33% 1 Missing ⚠️
sdgx/log.py 75.00% 1 Missing ⚠️
sdgx/models/ml/single_table/ctgan.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   71.20%   76.19%   +4.99%     
==========================================
  Files          46       52       +6     
  Lines        1823     2054     +231     
==========================================
+ Hits         1298     1565     +267     
+ Misses        525      489      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wh1isper Wh1isper marked this pull request as ready for review December 22, 2023 04:57
@Wh1isper Wh1isper enabled auto-merge (squash) December 22, 2023 10:22
@Wh1isper Wh1isper merged commit 4ea93b0 into main Dec 23, 2023
11 checks passed
@Wh1isper Wh1isper deleted the feature-cli branch December 27, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants