Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.2.0] Metadata Implementation #81
[0.2.0] Metadata Implementation #81
Changes from 20 commits
de083b8
7834da0
dd87ee1
14e83e6
06a14f2
ac89e8e
1c322d0
462b3cb
fb1565c
f6da1d3
7e65c83
329755b
f2d50f5
1f4ff08
10f0175
c027feb
9b026fc
c768a24
8af1e1d
ed30dad
f2e4954
44d0c61
75985e0
cfd2a11
644568f
c1b239c
d6077d6
89e4d1f
143eeb9
49e02c4
b2889da
8faa6e2
4cf8db0
98f4596
b50e41b
7687f77
ad312c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And composite_primary_key seems no effort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good idea to use a single list to be compatible with a single primary key or a composite primary key.
This problem also exists in multi-table-compbiner and will be modified together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a new exception in
sdgx/exceptions.py
? This will help us differentiate between what are expected exceptions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I didn't consider, I'll add new exceptions
MultiTableCombineError
andMetadataError
insdgx.exceptions
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better unit testing and bug fixing, I'd suggest synchronizing the main branch, which also includes
Exceptions
with error codes and exit codes