Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.2.0] Metadata Implementation #81
[0.2.0] Metadata Implementation #81
Changes from 27 commits
de083b8
7834da0
dd87ee1
14e83e6
06a14f2
ac89e8e
1c322d0
462b3cb
fb1565c
f6da1d3
7e65c83
329755b
f2d50f5
1f4ff08
10f0175
c027feb
9b026fc
c768a24
8af1e1d
ed30dad
f2e4954
44d0c61
75985e0
cfd2a11
644568f
c1b239c
d6077d6
89e4d1f
143eeb9
49e02c4
b2889da
8faa6e2
4cf8db0
98f4596
b50e41b
7687f77
ad312c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use
set(self.column_list) - set(all_dtype_columns)
here, which we can indicate all invalid keys once.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And maybe we can rename
MetadaError
toMetadataInvalidError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a more concise way of writing.
The current implementation is because the error information raised in these two cases is different, which may make it easier for users to locate the two error types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no conflict, just use two
if
-expressions instead of twofor-if
s.