Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.1.0] Intro NDArryLoader #75

Merged
merged 6 commits into from
Dec 19, 2023
Merged

[0.1.0] Intro NDArryLoader #75

merged 6 commits into from
Dec 19, 2023

Conversation

Wh1isper
Copy link
Collaborator

@Wh1isper Wh1isper commented Dec 18, 2023

Description

Motivation and Context

  • Introduce the NDArrayLoader for lazy reading of columnarly stored ndarry
  • Update docstring and examples

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

sweep-ai bot commented Dec 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@Wh1isper Wh1isper added this to the 0.1.0 milestone Dec 18, 2023
@Wh1isper Wh1isper marked this pull request as ready for review December 19, 2023 03:25
@Wh1isper
Copy link
Collaborator Author

@MooooCat
Please review the code first, I'm adding documentation.

@MooooCat
Copy link
Contributor

@MooooCat Please review the code first, I'm adding documentation.

Sure.

@Wh1isper
Copy link
Collaborator Author

Will update user guide before official release

@Wh1isper Wh1isper merged commit 482f7d5 into main Dec 19, 2023
11 checks passed
@Wh1isper Wh1isper deleted the 0.1.0-ndarryloader branch December 19, 2023 04:42
@MooooCat
Copy link
Contributor

MooooCat commented Dec 19, 2023

I have a question about the NDArray Loader.

I noticed that it names the .npy in order.

(I'm not sure if this will happen yet) When multiple data loaders run at the same time using default parameters (that is, the same cache_dir), this sequential naming method may cause conflicts:

NDArrayLoader 1 stores 1.npy ,then NDArrayLoader 2 store another Array, named 1.npy, on same ndarry_cache dir.

In the naming of cached .npy files, if the path contains an id field, there will be no such concern. Also, suggesting developers to use different cache paths is obviously a right approach.

Could this be a problem?

@Wh1isper
Copy link
Collaborator Author

@MooooCat Yes, different NDArrayLoader should use different subdirs. I'll draft a PR fot it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants