Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.1.0]Breaking changes: Reactoring models Part 1 #68

Merged
merged 11 commits into from
Dec 17, 2023

Conversation

Wh1isper
Copy link
Collaborator

@Wh1isper Wh1isper commented Dec 16, 2023

Description

Motivation and Context

  • Intro DiscreteInspector for CTGAN, which useful for guessing discrete columns
  • Metadata support(vanilla version for now)
  • Drop BSL packages, use their MIT Lincensed code

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

sweep-ai bot commented Dec 16, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@Wh1isper Wh1isper changed the title Reactoring models [0.1.0]Breaking changes: Reactoring models Dec 17, 2023
@Wh1isper
Copy link
Collaborator Author

Wh1isper commented Dec 17, 2023

Due to sdv-dev changed their license to BSL License, we copy the MIT licensed code into sdgx/models/components/sdv_*

See NOTICE: https://github.com/hitsz-ids/synthetic-data-generator/pull/68/files#diff-dfb14fbb9e7d095209ec4cfd621069437bf9c442ff9de9d4ce889781bd0fefcf

@Wh1isper Wh1isper changed the title [0.1.0]Breaking changes: Reactoring models [0.1.0]Breaking changes: Reactoring models Part 1 Dec 17, 2023
@Wh1isper Wh1isper marked this pull request as ready for review December 17, 2023 08:54
@Wh1isper Wh1isper changed the title [0.1.0]Breaking changes: Reactoring models Part 1 [0.1.0]Breaking changes: Reactoring models-Part 1 Dec 17, 2023
@Wh1isper
Copy link
Collaborator Author

Wh1isper commented Dec 17, 2023

@MooooCat

This is the first part of the refactoring model, mainly for the preparation of the replacement of CTGAN, which involves Inspector, Metadata and the replacement of BSL related packages(in #69).

In the second part, I will replace the current CTGAN implementation with our custom SynthesizerModel. This will achieve the basic functionality of version 0.1.0(as an library). And it will be the first preview version.

After this, I hope we can port the performance optimisations and compatibility modifications that we did before. A series of documentation updates and development of CLI tools will also be needed.

@Wh1isper Wh1isper added this to the 0.1.0 milestone Dec 17, 2023
@Wh1isper Wh1isper changed the title [0.1.0]Breaking changes: Reactoring models-Part 1 [0.1.0]Breaking changes: Reactoring models-Part 1-1 Dec 17, 2023
@Wh1isper
Copy link
Collaborator Author

For the sake of review, I've split the PR into two parts, the first being the Inspector and Metadata changes, and the other being the BSL Licence changes.

@MooooCat If there are no problems, I will first merge the second part into the 0.1.0-refactoring-model branch: #69 and merge this pr into main after passing the CI.

@MooooCat
Copy link
Contributor

For the sake of review, I've split the PR into two parts, the first being the Inspector and Metadata changes, and the other being the BSL Licence changes.

@MooooCat If there are no problems, I will first merge the second part into the 0.1.0-refactoring-model branch: #69 and merge this pr into main after passing the CI.

Cool, some algorithm-related branches in development may also synchronize the latest components.

* Cleaning dep

* Dropping BSL License package

* Fixing example(for now)
@Wh1isper Wh1isper changed the title [0.1.0]Breaking changes: Reactoring models-Part 1-1 [0.1.0]Breaking changes: Reactoring models Part 1 Dec 17, 2023
@Wh1isper Wh1isper merged commit fe5f01b into main Dec 17, 2023
11 checks passed
@Wh1isper Wh1isper deleted the 0.1.0-refactoring-model branch December 17, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants