Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.1.0: Intro DataConnector and DataLoader #64

Merged
merged 16 commits into from
Dec 14, 2023
Merged

0.1.0: Intro DataConnector and DataLoader #64

merged 16 commits into from
Dec 14, 2023

Conversation

Wh1isper
Copy link
Collaborator

@Wh1isper Wh1isper commented Dec 13, 2023 •
edited

Description

Motivation and Context

Part of 0.1.0 changes

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Wh1isper Wh1isper added the enhancement New feature or request label Dec 13, 2023
@Wh1isper Wh1isper self-assigned this Dec 13, 2023
@Wh1isper Wh1isper marked this pull request as draft December 13, 2023 03:35
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Dec 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@Wh1isper Wh1isper changed the title 0.1.0: Support DataConnector and DataLoader 0.1.0: Intro DataConnector and DataLoader Dec 13, 2023
@Wh1isper
Copy link
Collaborator Author

Wh1isper commented Dec 13, 2023 •
edited

Most of the content has been completed except for the documentation.

This PR contains the following main elements:

  • Data Connector and DataLoader implemented
  • Cacher for DataLoader and CacherManager for extensions
  • Some chore: docs build test, example...

I will merge this PR once the documentation has been added(and approved). Everyone can review code and comment first.

@Wh1isper Wh1isper marked this pull request as ready for review December 13, 2023 08:56
MooooCat
MooooCat approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@MooooCat MooooCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR improves the performance and usability of data related operations in SDG.

@Wh1isper Wh1isper merged commit 8800c62 into main Dec 14, 2023
11 checks passed
@Wh1isper Wh1isper deleted the 0.1.0-connector-and-loader branch December 14, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MooooCat MooooCat MooooCat approved these changes

Assignees

@Wh1isper Wh1isper

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wh1isper @MooooCat