Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDG's New Data Processor #48

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Update SDG's New Data Processor #48

merged 6 commits into from
Dec 5, 2023

Conversation

MooooCat
Copy link
Contributor

@MooooCat MooooCat commented Dec 4, 2023 •
edited

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Dec 4, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@Wh1isper Wh1isper self-requested a review December 5, 2023 10:06
@MooooCat MooooCat marked this pull request as ready for review December 5, 2023 13:02
@MooooCat MooooCat removed the request for review from Wh1isper December 5, 2023 13:04
@MooooCat
Copy link
Contributor Author

MooooCat commented Dec 5, 2023

Merge important file structure changes, other developers may work on modules in the data process separately.

@MooooCat MooooCat merged commit 86f7710 into main Dec 5, 2023
7 checks passed
@MooooCat MooooCat deleted the feature-Data_Processor branch December 5, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MooooCat