Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local install error #39

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix local install error #39

merged 1 commit into from
Oct 31, 2023

Conversation

MooooCat
Copy link
Contributor

Description

In this PR we fixed a bug with local installation of sdgx.

Motivation and Context

In some python versions, using setup.py will cause errors, so we still use pyproject.toml for local installation.

The relevant explanatory text in the readme document has also been updated simultaneously.

How has this been tested?

The local installation has been tested. Since it does not involve functional changes, it will not cause extra problems.

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@MooooCat MooooCat merged commit 1771ebe into main Oct 31, 2023
6 checks passed
@MooooCat MooooCat deleted the bugfix-local_install branch October 31, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant