Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull: Support NPZ format in current transformer #167

Open
wants to merge 92 commits into
base: feature-npz-support
Choose a base branch
from

Conversation

sirisneupane123
Copy link

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.09%. Comparing base (861f5b6) to head (f8dc42d).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   80.09%   80.09%           
=======================================
  Files          69       69           
  Lines        3305     3305           
=======================================
  Hits         2647     2647           
  Misses        658      658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooooCat
Copy link
Contributor

@sirisneupane123 @sam3179 Thank you for the PR.

We'll also do some code review later.

Viewing from the current code structure, demo.py should be moved to the example/ directory (and renamed), and test should be added to the existing unit tests in the tests/ directory.

@MooooCat MooooCat changed the title pull pull: Support NPZ format in current transformer Mar 27, 2024
@MooooCat MooooCat changed the base branch from main to feature-npz-support March 27, 2024 02:35
@Wh1isper
Copy link
Collaborator

Why is there a test case in sdgx/models/components/sdv_ctgan/data_transformer_test.py and it's using unittest's style

Is there any reason not to put it under tests, as well as not using pytest?

pre-commit-ci bot and others added 30 commits April 29, 2024 18:19
…ping in the debugging of issues related to incorrect model versions being used or misconfigured paths.
… from a file or directly passed as an object. It's particularly useful when errors may be associated with metadata formatting or source, or maybe in complex systems where multiple metadata configurations might exist.
…synthesizer with metadata and data processors
FAQ: by Siris Neupane
FAQ by Siris Neupane
# Conflicts:
#	sdgx/data_models/metadata.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants