Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix function's arg default List #14

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

MooooCat
Copy link
Contributor

根据 @wunder957#12 提供内容修改到 CTGAN 类中.

@wunder957
Copy link
Contributor

@MooooCatOptional[list]可以明确这是一个可选的列表,也可以是Optional[Iterable[str]]这会允许用户传入一个可迭代的字符串,我不清楚这里用后者是否正确,但是用前者一定没问题

@wunder957
Copy link
Contributor

或许从这里开始我们可以逐渐添加公共接口的type hint

@MooooCat MooooCat merged commit 701abcc into dev Aug 22, 2023
2 checks passed
@MooooCat MooooCat deleted the bugfix_func-arg-default-list branch August 22, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants