Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish int/float in NumericInspector #133

Merged
merged 6 commits into from
Feb 4, 2024

Conversation

MooooCat
Copy link
Contributor

@MooooCat MooooCat commented Feb 4, 2024

Description

We have made a small upgrade to sdgx.data_models.inspectors.numeric.NumericInspector, adding a feature to identify int / float data types.

Motivation and Context

Previously, NumericInspector mark both int / float types as numeric types, but in fact we can further distinguish int and float, which involves two aspects:

  • Currently, our numeric types are processed as float during model inference, resulting in the appearance of the generated data being somewhat different from the original data. To fix this, the first requires accurately separating int and float (the current determination method of pd.DataFrame is not accurate );
  • Future post-processing processes can be processed separately according to int / float types, thus completely solving the above problems.

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4677f9d) 80.05% compared to head (86cc0b9) 80.26%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   80.05%   80.26%   +0.21%     
==========================================
  Files          66       66              
  Lines        2943     2975      +32     
==========================================
+ Hits         2356     2388      +32     
  Misses        587      587              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooooCat MooooCat marked this pull request as ready for review February 4, 2024 03:53
@MooooCat MooooCat merged commit ff2022b into main Feb 4, 2024
11 checks passed
@MooooCat MooooCat deleted the feature-split-int/float-in-inspector branch February 7, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants