Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some modifications on copula #132

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

MooooCat
Copy link
Contributor

@MooooCat MooooCat commented Feb 1, 2024

Description

We made some updates to the copula to accommodate development calls for other composite algorithms.

Motivation and Context

The current main modifications are as follows:

  • Added type hints;
  • Changed the metadata settings to adapt to sdgx's Metadata and other components;
  • Changed the properties of some private methods to make them accessible to other algorithms.

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MooooCat
Copy link
Contributor Author

MooooCat commented Feb 1, 2024

@sjh120 Please check whether the current modifications can meet the development needs of the multi-table algorithm in sdg_ee. If not, you can continue to modify the code on this branch. You are welcome to initiate discussions at any time.

@hitsz-ids hitsz-ids deleted a comment from sweep-ai bot Feb 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1e4105d) 80.05% compared to head (a8ea428) 82.75%.
Report is 1 commits behind head on main.

Files Patch % Lines
sdgx/models/statistics/single_table/copula.py 68.75% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   80.05%   82.75%   +2.69%     
==========================================
  Files          66       65       -1     
  Lines        2943     2812     -131     
==========================================
- Hits         2356     2327      -29     
+ Misses        587      485     -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooooCat MooooCat added the enhancement New feature or request label Feb 28, 2024
@MooooCat MooooCat added this to the 0.2.1 milestone Mar 1, 2024
@MooooCat MooooCat modified the milestones: 0.2.1, 1.0.0 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants